refactor: improve MoveItemToTrash error description #23589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
force-pushed
the
better-trash-description-macos
branch
from
3303490
to
cfc899b
Compare
zcbenz
approved these changes
May 18, 2020
|
Release Notes Persisted
|
This was referenced May 18, 2020
|
I have automatically backported this PR to "9-x-y", please check out #23628 |
|
I have automatically backported this PR to "8-x-y", please check out #23629 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Very mild refactor to
MoveItemToTrashon macOS - when failure occurred we would LOG that a failure occurred but not make the failure's underlying cause available to the user, which would help them better diagnose that failure. This improves that experience by ensuring that the localized error description is included in the log.cc @ckerr @jkleinsc
Checklist
npm testpassesRelease Notes
Notes: Improved error logging on
moveItemToTrashfailures on macOS.