Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omit old PRs from X.0.0 release notes #23325

Closed
wants to merge 18 commits into from

Conversation

ckerr
Copy link
Member

@ckerr ckerr commented Apr 29, 2020

Description of Change

In X.0.0 releases, skip PRs that have already been backported and released to older branches.

CC @codebytere because she's shown interest, but anyone is welcome to review

Checklist

Release Notes

Notes: none

@ckerr ckerr requested a review from a team as a code owner April 29, 2020 05:26
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 29, 2020
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but it would be great to add tests. We should be able to use mock data to exercise the notes generator.

script/release/notes/notes.js Outdated Show resolved Hide resolved
@ckerr
Copy link
Member Author

ckerr commented Apr 29, 2020

(rebased to master pick up #23266 to try to fix the lint error)

@ckerr
Copy link
Member Author

ckerr commented Apr 29, 2020

argh

@ckerr ckerr mentioned this pull request Apr 29, 2020
4 tasks
@ckerr
Copy link
Member Author

ckerr commented Apr 29, 2020

Superceded by #23335

@ckerr ckerr closed this Apr 29, 2020
@ckerr ckerr deleted the omit-old-fixes-from-release-notes branch April 29, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants