Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: use build/include_directory for NOLINT #23300

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 27, 2020

Backport of #23266

See that PR for details.

Notes: none

build/include linter was splitted to build/include_directory at
depot_tools upstream.

https://crrev.com/c/2159690
https://crbug.com/1073191
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 27, 2020
@trop trop bot added 9-x-y backport This is a backport PR labels Apr 27, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 27, 2020
@MarshallOfSound
Copy link
Member

Merging as this only impacts lint which has passed

@MarshallOfSound MarshallOfSound added the fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases label Apr 27, 2020
@MarshallOfSound MarshallOfSound merged commit 729019b into 9-x-y Apr 27, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 27, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the trop/9-x-y-bp-style-use-build-include_directory-for-nolint-1588018965092 branch April 27, 2020 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants