Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not mutate ipc instances across contexts #23236

Merged
merged 1 commit into from Apr 22, 2020
Merged

fix: do not mutate ipc instances across contexts #23236

merged 1 commit into from Apr 22, 2020

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Apr 22, 2020 •
edited

IPC is shared across contexts sometimes, this stops us mutating IPC instances that have already been initialized in another context. This can be removed once content_script and isolated_init have been completely removed

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 22, 2020
nornagon
nornagon approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bleh

@MarshallOfSound MarshallOfSound merged commit 8262f24 into master Apr 22, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 22, 2020

No Release Notes

@MarshallOfSound MarshallOfSound deleted the no-ipc-mutate branch April 22, 2020 23:36
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

I was unable to backport this PR to "7-2-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

I was unable to backport this PR to "6-1-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@MarshallOfSound MarshallOfSound mentioned this pull request Apr 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

@MarshallOfSound has manually backported this PR to "9-x-y", please check out #23238

@MarshallOfSound MarshallOfSound mentioned this pull request Apr 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

@MarshallOfSound has manually backported this PR to "7-2-x", please check out #23239

@trop trop bot added the in-flight/7-2-x label Apr 22, 2020
@MarshallOfSound MarshallOfSound mentioned this pull request Apr 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

@MarshallOfSound has manually backported this PR to "8-x-y", please check out #23240

@MarshallOfSound MarshallOfSound mentioned this pull request Apr 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

@MarshallOfSound has manually backported this PR to "6-1-x", please check out #23241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

Assignees
No one assigned
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @nornagon