fix: use Node's microtasks policy in node_main.cc #23234

ckerr · 2020-04-22T22:14:45Z

Backport of #23154. Fixes #21515 for the 8-x-y branch.

Manually backport #23154 because the diff generated by trop didn't work. The line numbers have changed but the code remains the same.

PR description included and stakeholders cc'd
npm test passes
tests are changed or added
PR title follows semantic commit guidelines
PR release notes describe the change in a way relevant to app developers, and are capitalized, punctuated, and past tense.

Notes: Fixed Promise timeout issue when running Electron as Node.

release-clerk · 2020-04-23T18:00:37Z

Release Notes Persisted

Fixed Promise timeout issue when running Electron as Node.

fix: use Node's microtasks policy in node_main.cc

5ebd41f

electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 22, 2020

trop bot mentioned this pull request Apr 22, 2020

await Promise with Timer behavior regress from previous version #21515

Closed

3 tasks

trop bot added 8-x-y backport This is a backport PR labels Apr 22, 2020

electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 22, 2020

ckerr added the merged/target/7-2-x label Apr 22, 2020

codebytere removed the merged/target/7-2-x label Apr 23, 2020

codebytere approved these changes Apr 23, 2020

View reviewed changes

codebytere merged commit ce04014 into 8-x-y Apr 23, 2020

codebytere deleted the use-nodes-microtask-policy_8-x-y branch April 23, 2020 18:00

Provide feedback