Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not allow child windows to specify their own preload script #23226

Merged
merged 1 commit into from Apr 22, 2020
Merged

fix: do not allow child windows to specify their own preload script #23226

merged 1 commit into from Apr 22, 2020

Conversation

MarshallOfSound
Copy link
Member

This is a potential path for escalation. There is no reason for a renderer to be able to choose it's own preload script.

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 22, 2020
@MarshallOfSound MarshallOfSound merged commit 375b793 into master Apr 22, 2020
@MarshallOfSound MarshallOfSound deleted the no-child-window-preload-feature-string branch April 22, 2020 19:43
@release-clerk
Copy link

release-clerk bot commented Apr 22, 2020

No Release Notes

@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

I was unable to backport this PR to "6-1-x" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/6-1-x label Apr 22, 2020
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

I was unable to backport this PR to "7-2-x" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@MarshallOfSound MarshallOfSound mentioned this pull request Apr 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

@MarshallOfSound has manually backported this PR to "9-x-y", please check out #23227

@MarshallOfSound MarshallOfSound mentioned this pull request Apr 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

@MarshallOfSound has manually backported this PR to "6-1-x", please check out #23228

@MarshallOfSound MarshallOfSound mentioned this pull request Apr 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

@MarshallOfSound has manually backported this PR to "7-2-x", please check out #23229

@MarshallOfSound MarshallOfSound mentioned this pull request Apr 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Apr 22, 2020

@MarshallOfSound has manually backported this PR to "8-x-y", please check out #23230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
new-pr 🌱 PR opened in the last 24 hours
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarshallOfSound @nornagon @deepak1556