Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: block custom window.open when nativeWindowOpen is true #23222

Merged
merged 2 commits into from Apr 23, 2020
Merged

fix: block custom window.open when nativeWindowOpen is true #23222

merged 2 commits into from Apr 23, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Apr 22, 2020 •
edited by nornagon

Backport of #23188

See that PR for details.

Notes: Fixed an issue where windows without nativeWindowOpen: true could invoke the non-native-open path.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 22, 2020
@trop trop bot requested a review from nornagon April 22, 2020 17:49
@trop trop bot mentioned this pull request Apr 22, 2020
Merged
5 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Apr 22, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 22, 2020
@MarshallOfSound MarshallOfSound merged commit 963ef4d into 9-x-y Apr 23, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 23, 2020

Release Notes Persisted

Fixed an issue where windows without nativeWindowOpen: true could invoke the non-native-open path.

@MarshallOfSound MarshallOfSound deleted the trop/9-x-y-bp-fix-block-custom-window-open-when-nativewindowopen-is-true-1587577751990 branch April 23, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarshallOfSound @nornagon