fix: ensure that functions are not retained beyond their context being released #23207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
requested changes
Apr 21, 2020
shell/renderer/api/context_bridge/render_frame_function_store.cc
Outdated
Show resolved
Hide resolved
MarshallOfSound
force-pushed
the
clean-up-function-store-on-context-release
branch
from
ecb6317
to
e012274
Compare
nornagon
reviewed
Apr 21, 2020
MarshallOfSound
force-pushed
the
clean-up-function-store-on-context-release
branch
from
e012274
to
18f7178
Compare
nornagon
approved these changes
Apr 21, 2020
|
Release Notes Persisted
|
|
I was unable to backport this PR to "7-2-x" cleanly; |
|
I was unable to backport this PR to "8-x-y" cleanly; |
|
I have automatically backported this PR to "9-x-y", please check out #23209 |
|
@MarshallOfSound has manually backported this PR to "8-x-y", please check out #23231 |
MarshallOfSound
added a commit
that referenced
this pull request
Apr 22, 2020
|
@MarshallOfSound has manually backported this PR to "7-2-x", please check out #23232 |
MarshallOfSound
added a commit
that referenced
this pull request
Apr 22, 2020
MarshallOfSound
added a commit
that referenced
this pull request
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were cleaning up the
RenderFrameFunctionStoreinstances when a render frame was destroyed. For same site navigations / reloads the render frame isn't destroyed, it's reused so we were leaking the old context and all the functions. This updates our impl to listen for WillReleaseScriptContext and release our holds on objects in that context once that context is about to be released.Also adds a test for good measure 😄 Had to update the contextBridge specs to use an actual HTTP server so that same-site rules applied
Notes: fixed memory leak when using contextBridge with sandbox=true