Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: heap-use-after-free in tray.popUpContextMenu #23181

Merged
merged 1 commit into from Apr 21, 2020
Merged

fix: heap-use-after-free in tray.popUpContextMenu #23181

merged 1 commit into from Apr 21, 2020
+15 −0

Conversation

nornagon
Copy link
Member

Backport of #22842. See that change for details.

Notes: Fixed a use-after-free error that could happen if a Tray was destroyed while showing a custom context menu.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 20, 2020
@trop trop bot mentioned this pull request Apr 20, 2020
Merged
5 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Apr 20, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 20, 2020
codebytere
codebytere approved these changes Apr 21, 2020
View reviewed changes
Copy link
Member

@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending rebase on #23187

@nornagon nornagon merged commit 5b3b09f into 8-x-y Apr 21, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 21, 2020

Release Notes Persisted

Fixed a use-after-free error that could happen if a Tray was destroyed while showing a custom context menu.

@nornagon nornagon deleted the backport/8-x-y/fix-tray-context-menu-uaf branch April 21, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @codebytere