feat: add new render-process-gone event #23096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
reviewed
Apr 13, 2020
MarshallOfSound
force-pushed
the
feat/render-process-gone
branch
from
bc9bb65
to
b32549e
Compare
zcbenz
approved these changes
May 11, 2020
|
Release Notes Persisted
|
6 tasks
|
/trop run backport-to 8-x-y |
|
The backport process for this PR has been manually initiated - |
|
I have automatically backported this PR to "8-x-y", please check out #24308 |
|
/trop run backport-to 9-x-y |
|
The backport process for this PR has been manually initiated - |
|
I have automatically backported this PR to "9-x-y", please check out #24309 |
|
@MarshallOfSound Can I safely access the |
|
Maybe this PR addresses that concern |
hacdias
added a commit
to ipfs/ipfs-desktop
that referenced
this pull request
Jan 10, 2022
electron/electron#23096 License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
added a commit
to ipfs/ipfs-desktop
that referenced
this pull request
Jan 21, 2022
electron/electron#23096 License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
hacdias
added a commit
to ipfs/ipfs-desktop
that referenced
this pull request
Jan 21, 2022
electron/electron#23096 License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
lidel
added a commit
to ipfs/ipfs-desktop
that referenced
this pull request
Feb 1, 2022
* refactor: replace deprecated 'crashed' event electron/electron#23096 * feat: ux element when window becomes unresponsive * style: improved helptext dedicated button labels remove any ambiguity Co-authored-by: Marcin Rataj <lidel@lidel.org>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
crashedevent could fire for a number of reasons, some of which are nothing to do with crashes. It also was losing some helpful information about why the process crashed. This PR leaves that event untouched (as per our new breaking changes policy) and adds a new event that contains more information (the actualreasonthe process crashed) and puts it in an object for easier expandability later.Notes: Added new
render-process-goneevent to replace thecrashedevent.