Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't assign NSAlert to window which is not visible #23089

Merged
merged 4 commits into from Apr 14, 2020
Merged

fix: don't assign NSAlert to window which is not visible #23089

merged 4 commits into from Apr 14, 2020

Commits on Apr 13, 2020

  1. fix: don't assign NSAlert to window which is not visible 

    Without this change it's possible to create message box which can't
be dismissed on mac.
    @CezaryKulakowski @electron-bot
    CezaryKulakowski authored and electron-bot committed Apr 13, 2020
    Copy the full SHA
    3fa2737 View commit details
    Browse the repository at this point in the history

  2. fixup! fix: don't assign NSAlert to window which is not visible

    @CezaryKulakowski @electron-bot
    CezaryKulakowski authored and electron-bot committed Apr 13, 2020
    Copy the full SHA
    aa7f15b View commit details
    Browse the repository at this point in the history

  3. fixup! fix: don't assign NSAlert to window which is not visible

    @CezaryKulakowski @electron-bot
    CezaryKulakowski authored and electron-bot committed Apr 13, 2020
    Copy the full SHA
    9143045 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2020

  1. Update docs/api/dialog.md

    John Kleinschmidt committed Apr 14, 2020
    Copy the full SHA
    0ab24f3 View commit details
    Browse the repository at this point in the history