Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: persist maximizable state when toggling fullscreen #22988

Merged
merged 1 commit into from Apr 8, 2020
Merged

fix: persist maximizable state when toggling fullscreen #22988

merged 1 commit into from Apr 8, 2020

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Apr 6, 2020 •
edited

Description of Change

Closes #22963.

Exiting fullscreen on macOS via Toggle Fullscreen causes Cocoa to redraw the NSWindow, which resets the enabled state for NSWindowZoomButton. If maximizable was false, the zoom button would suddenly become enabled when a user hit Toggle Fullscreen fullscreen twice, leading to state drift. This fixes that.

Tested with https://gist.github.com/88dfab886b69cd83cafb28e85d1dcdd4.

cc @nornagon @zcbenz

Checklist

Release Notes

Notes: Fixed an issue with maximizable state persistence of BrowserWindows on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Apr 6, 2020
nornagon
nornagon approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@nornagon nornagon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gross

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Apr 7, 2020
@codebytere codebytere merged commit a7469f8 into master Apr 8, 2020
@release-clerk
Copy link

release-clerk bot commented Apr 8, 2020

Release Notes Persisted

Fixed an issue with maximizable state persistence of BrowserWindows on macOS.

@codebytere codebytere deleted the persist-maximizable-state branch April 8, 2020 03:40
This was referenced Apr 8, 2020
Merged
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Apr 8, 2020

I have automatically backported this PR to "7-2-x", please check out #23019

@trop
Copy link
Contributor

trop bot commented Apr 8, 2020

I have automatically backported this PR to "8-x-y", please check out #23020

@trop trop bot removed the target/8-x-y label Apr 8, 2020
@trop
Copy link
Contributor

trop bot commented Apr 8, 2020

I have automatically backported this PR to "9-x-y", please check out #23021

@trop trop bot added the merged/7-2-x label Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Window with customButtonsOnHover crashes
3 participants
@codebytere @nornagon @zcbenz