fix: Add ContentsView to AXChildren #22399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixrieseberg
force-pushed
the
axchildren
branch
from
e42de1b
to
17aeafa
Compare
codebytere
approved these changes
Feb 28, 2020
|
Release Notes Persisted
|
This was referenced Mar 2, 2020
|
I have automatically backported this PR to "9-x-y", please check out #22469 |
|
I have automatically backported this PR to "8-x-y", please check out #22470 |
faultyserver
added a commit
to discord/electron
that referenced
this pull request
Apr 8, 2020
faultyserver
added a commit
to discord/electron
that referenced
this pull request
Apr 8, 2020
adill
pushed a commit
to discord/electron
that referenced
this pull request
Apr 11, 2020
|
/trop run backport-to 7-2-x |
|
The backport process for this PR has been manually initiated - |
|
I have automatically backported this PR to "7-2-x", please check out #23174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The native window on macOS has only three elements in its
AXChildren: The close, maximize, and minimize button. In practice, that means that a VoiceOver user won't be able to navigate from the window into the web contents, therefore unable to interact with anything that's actually happening in the window.In this PR, I'm manually editing the
AXChildrenarray and adding theContentsViewback in. I have to admit that I have little experience with accessibility work in Cocoa, but I believe that it fixes the issue. I also have no idea how we could write a test for this, but I'm open to ideas!Closes #17207
Before
After
Checklist
npm testpassesRelease Notes
Notes: macOS VoiceOver is now able to find its way back into web contents after it navigated "out" of an application.