Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(extensions): devtools now open for background pages #22217

Merged
merged 1 commit into from Sep 8, 2020
Merged

fix(extensions): devtools now open for background pages #22217

merged 1 commit into from Sep 8, 2020

Conversation

samuelmaddock
Copy link
Member

@samuelmaddock samuelmaddock commented Feb 17, 2020 •
edited

Description of Change

Ref #19447

This fixes DevTools not opening with Chrome extension background pages.

  • Assign WebContents type based on ViewType user data.
  • Manage background page WebContents to enable opening devtools.

Electron maintainers, please add 9-x-y backport label.

TODO:

  • Fix ExtensionHost crash on shutdown; likely related to managed_web_contents deleting WebContents instance.
  • Fix crashes? or is it just flaky tests?

Checklist

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Feb 17, 2020
@samuelmaddock samuelmaddock marked this pull request as ready for review March 2, 2020 17:39
@samuelmaddock samuelmaddock changed the title [wip] fix(extensions): devtools now open for background pages fix(extensions): devtools now open for background pages Mar 2, 2020
@samuelmaddock samuelmaddock mentioned this pull request Mar 2, 2020
Closed
11 tasks
zcbenz
zcbenz approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@samuelmaddock samuelmaddock changed the title fix(extensions): devtools now open for background pages [wip] fix(extensions): devtools now open for background pages Mar 6, 2020
@samuelmaddock samuelmaddock force-pushed the fix-bgpage-devtools branch 2 times, most recently from 6d2a859 to da5464e Compare March 7, 2020 00:02
@zcbenz zcbenz added the wip ⚒ label Mar 20, 2020
@sentialx
Copy link
Contributor

Is there any chance that it could be merged?

@samuelmaddock
fix(extensions): devtools now open for background pages
b021bc1 
refactor(extensions): remove unused InitWithBrowserContext method

fix(extensions): release background page WebContents to avoid crash

The background page WebContents instance is managed by the ExtensionHost.

fix(extensions): open background page devtools detached by default

test(extensions): add background page devtools test

chore: test fix for null web_contents()

fix: close background page devtools in test after opening
@samuelmaddock samuelmaddock changed the title [wip] fix(extensions): devtools now open for background pages fix(extensions): devtools now open for background pages Sep 6, 2020
@samuelmaddock
Copy link
Member Author

@zcbenz I fixed this up so it's no longer a WIP, the label can be removed now.

@zcbenz zcbenz removed the wip ⚒ label Sep 8, 2020
@zcbenz zcbenz merged commit 5a8046c into electron:master Sep 8, 2020
@release-clerk
Copy link

release-clerk bot commented Sep 8, 2020

No Release Notes

@trop
Copy link
Contributor

trop bot commented Sep 8, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/10-x-y label Sep 8, 2020
@trop
Copy link
Contributor

trop bot commented Sep 8, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot mentioned this pull request Sep 8, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Sep 8, 2020

I have automatically backported this PR to "11-x-y", please check out #25366

@codebytere
Copy link
Member

@samuelmaddock could you do backports for this?

samuelmaddock added a commit to samuelmaddock/electron that referenced this pull request Sep 22, 2020
@samuelmaddock
fix(extensions): devtools now open for background pages (electron#22217)
18f0cf6 
refactor(extensions): remove unused InitWithBrowserContext method

fix(extensions): release background page WebContents to avoid crash

The background page WebContents instance is managed by the ExtensionHost.

fix(extensions): open background page devtools detached by default

test(extensions): add background page devtools test

chore: test fix for null web_contents()

fix: close background page devtools in test after opening
samuelmaddock added a commit to samuelmaddock/electron that referenced this pull request Sep 22, 2020
@samuelmaddock
fix(extensions): devtools now open for background pages (electron#22217)
927e29e 
refactor(extensions): remove unused InitWithBrowserContext method

fix(extensions): release background page WebContents to avoid crash

The background page WebContents instance is managed by the ExtensionHost.

fix(extensions): open background page devtools detached by default

test(extensions): add background page devtools test

chore: test fix for null web_contents()

fix: close background page devtools in test after opening
@samuelmaddock samuelmaddock mentioned this pull request Sep 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Sep 22, 2020

@samuelmaddock has manually backported this PR to "10-x-y", please check out #25566

@samuelmaddock samuelmaddock mentioned this pull request Sep 22, 2020
Merged
@trop
Copy link
Contributor

trop bot commented Sep 22, 2020

@samuelmaddock has manually backported this PR to "9-x-y", please check out #25567

@samuelmaddock samuelmaddock deleted the fix-bgpage-devtools branch September 22, 2020 04:04
@samuelmaddock
Copy link
Member Author

@codebytere done 👍

@samuelmaddock samuelmaddock mentioned this pull request Oct 19, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@samuelmaddock @sentialx @codebytere @nornagon @zcbenz @jkleinsc @MarshallOfSound