New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [extensions] implement a couple of tabs APIs #21779
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 👍
IDR_IME_SERVICE_MOJOM_JS); | ||
source_map->RegisterSource("chromeos.ime.service", | ||
IDR_IME_SERVICE_BINDINGS_JS); | ||
#endif // defined(OS_CHROMEOS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could remove this section since it's related to Chrome OS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming lint issues are addressed.
win32 failure unrelated |
No Release Notes |
Description of Change
This (sort of) implements chrome.tabs.executeScript. It only works with non-negative tab IDs (i.e. the default of "active tab" will throw a validation error), and it makes no special effort to prevent extensions from accessing "tabs" they haven't requested permission to (though there does seem to be at least some protections in place in the code I've added, mostly copied from Chrome. I'm not sure if those are watertight though.)
Also implements chrome.tabs.sendMessage, which the Ember DevTools extension depends on.
This is enough to get the React and Ember DevTools extensions working when
enable_electron_extensions = true
.Ref #19447
Checklist
npm test
passesRelease Notes
Notes: none