Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [extensions] background pages #21591

Merged
merged 5 commits into from Jan 13, 2020
Merged

feat: [extensions] background pages #21591

merged 5 commits into from Jan 13, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Dec 20, 2019 •
edited

Description of Change

This adds support for lazy background pages when building with ENABLE_ELECTRON_EXTENSIONS. One step closer to a functional React DevTools!

NB. no release notes because this feature is still behind the ENABLE_ELECTRON_EXTENSIONS flag, which is not enabled in Electron release builds.

Ref #19447

Checklist

Release Notes

Notes: none

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Dec 20, 2019
@nornagon nornagon mentioned this pull request Dec 20, 2019
Closed
11 tasks
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Dec 21, 2019
samuelmaddock
samuelmaddock reviewed Jan 12, 2020
View reviewed changes
Copy link
Member

@samuelmaddock samuelmaddock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments. It looks surprisingly straightforward to add background page support after reading through the code, nice!

electron_paks.gni Outdated Show resolved Hide resolved
shell/browser/extensions/electron_extensions_api_client.cc Show resolved Hide resolved
shell/browser/extensions/atom_extensions_browser_client.cc
: api_client_(new extensions::ExtensionsAPIClient),
// : api_client_(new extensions::AtomExtensionsAPIClient),
: api_client_(new extensions::ElectronExtensionsAPIClient),
process_manager_delegate_(new extensions::ElectronProcessManagerDelegate),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random thought while reading this code. It might be cool if the extensions system could be configured at startup from the JS runtime. That way only projects interested in using extensions could opt-in to initializing all of these subsystems.

zcbenz
zcbenz approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@zcbenz zcbenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

MarshallOfSound
MarshallOfSound approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

nornagon
nornagon commented Jan 13, 2020
View reviewed changes
electron_paks.gni Outdated Show resolved Hide resolved
@nornagon nornagon merged commit 8bc0c92 into master Jan 13, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 13, 2020

No Release Notes

@nornagon nornagon deleted the extensions-background-pages branch January 13, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelmaddock samuelmaddock samuelmaddock left review comments

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nornagon @zcbenz @samuelmaddock @MarshallOfSound