Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent menu gc during popup #20785

Merged
merged 1 commit into from Oct 29, 2019
Merged

fix: prevent menu gc during popup #20785

merged 1 commit into from Oct 29, 2019

Conversation

codebytere
Copy link
Member

Description of Change

Backport of #20745.

Release Notes

Notes: Fixed a crash in Menus related to menu.popup().

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Oct 28, 2019
@trop trop bot mentioned this pull request Oct 28, 2019
Merged
4 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Oct 28, 2019
@codebytere codebytere added target/5-0-x and removed 8-x-y backport This is a backport PR labels Oct 28, 2019
@codebytere codebytere requested a review from a team October 28, 2019 18:48
@codebytere codebytere added 8-x-y backport This is a backport PR and removed new-pr 🌱 PR opened in the last 24 hours target/5-0-x labels Oct 28, 2019
@zcbenz zcbenz merged commit f77bd19 into 8-x-y Oct 29, 2019
@release-clerk
Copy link

release-clerk bot commented Oct 29, 2019

Release Notes Persisted

Fixed a crash in Menus related to menu.popup().

@zcbenz zcbenz deleted the bp-menu-crash-8 branch October 29, 2019 04:21
@trop trop bot mentioned this pull request Oct 29, 2019
Merged
@trop
Copy link
Contributor

trop bot commented Oct 29, 2019

I have automatically backported this PR to "7-0-x", please check out #20808

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@codebytere @zcbenz @MarshallOfSound