fix: don't call SetBounds on restore #19886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electron-cation
bot
added
new-pr 🌱
4 tasks
zcbenz
approved these changes
Aug 26, 2019
|
There is conflict needs to be resolved. |
brenca
force-pushed
the
brenca/unresizable-window-sizing-fix
branch
from
9f50ea1
to
eb31741
Compare
|
@zcbenz I resolved the conflict! |
codebytere
approved these changes
Aug 26, 2019
|
Release Notes Persisted
|
|
I have automatically backported this PR to "6-0-x", please check out #19956 |
|
I have automatically backported this PR to "7-0-x", please check out #19957 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a revert of #8047, the issues mentioned there are not reproducible after the revert (in fact #7951 resurfaced, and this fixes that). Since the issue mentioned in the comments (#2498) is about frameless window sizing and the PR I created to improve that landed in
6-0-x, I'm only backporting until that to make sure not to re-introduce the original bug.Fixes #13043.
Fixes #16900.
Checklist
npm testpassesRelease Notes
Notes: Fix a bug where an unresizable window would shrink when restored after being minimized on Windows.