build: start building Windows on Arm builds #19780
Conversation
(cherry picked from commit 4064e1f)
|
Current Azure Pipeline failure could be related to microsoft/azure-pipelines-tasks#8418 (summary: they're including an x64 version of 7Zip, even for x86 platforms - Windows on Arm does not support emulating x64 stuff). |
|
The current failure looks like VSTS is trying to execute electron.exe without a desktop attached (I saw similar issues trying to run it on a device with a remote session). Downloading dist.zip onto an arm64 device, unpacking it and running electron.exe seems to work fine. The WinAppDriver (https://blogs.windows.com/windowsdeveloper/2019/05/13/announcing-ui-tests-in-ci-cd-for-desktop-app-developers/#Mzaq4j4qGai8lDt2.97) may let you run things interactively. |
|
Actually, I also found https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/v2-windows?view=azure-devops#download-and-configure-the-agent - probably best to make sure that the agent is running in interactive mode (though there are some security implications for doing this). |
|
|
||
| - script: | | ||
| cd src | ||
| set npm_config_nodedir=%cd%\out\Default\gen\node_headers |
There was a problem hiding this comment.
Probably also need to set npm_config_arch=arm64 here too if it's not being set somewhere else in the environment.
jkleinsc
changed the title
|
Cool, so the latest test result I have on the master branch (1dc02e6), running on Windows 10 Version 1903 (build 18362.295, current retail release) should have approximately 3-4 unit test failures. |
| @@ -89,6 +89,10 @@ build_script: | |||
| - appveyor PushArtifact out/Default/dist.zip | |||
| - appveyor PushArtifact out/Default/chromedriver.zip | |||
| - appveyor PushArtifact out/ffmpeg/ffmpeg.zip | |||
| - 7z a node_headers.zip out\Default\gen\node_headers | |||
There was a problem hiding this comment.
Can you rely on utility from standard powershell https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.archive/compress-archive?view=powershell-6 to avoid some accidental breakage in future :)
There was a problem hiding this comment.
@deepak1556 it looks like the version of Powershell we have on our CI vms doesn't support this command: https://ci.appveyor.com/project/electron-bot/electron-ldhmv/builds/26839690
azure-pipelines-woa.yml
Outdated
| cd src | ||
| echo "Running test suite" | ||
| .\out\Default\electron.exe --version | ||
| .\out\Default\electron.exe electron\spec --ci --enable-logging |
There was a problem hiding this comment.
shouldn't we also run spec-main ? would be better to just call npm run test ?
| $localArtifactPath = "$pwd\dist.zip" | ||
| $serverArtifactPath = "$env:APPVEYOR_URL/buildjobs/$env:APPVEYOR_JOB_ID/artifacts/dist.zip" | ||
| Invoke-RestMethod -Method Get -Uri $serverArtifactPath -OutFile $localArtifactPath -Headers @{ "Authorization" = "Bearer $env:APPVEYOR_TOKEN" } | ||
| & "${env:ProgramFiles(x86)}\7-Zip\7z.exe" x -osrc\out\Default -y $localArtifactPath |
There was a problem hiding this comment.
@jkleinsc we must make sure that d3dcompiler_47.dll version difference doesn't impact users when relying on our release. I don't have the hardware to test this scenario, a task for followup.
|
No Release Notes |
|
I was unable to backport this PR to "6-0-x" cleanly; |
|
I have automatically backported this PR to "7-0-x", please check out #19874 |
(cherry picked from commit 4bc7b3b)
|
A maintainer has manually backported this PR to "6-0-x", please check out #19910 |
Description of Change
Adds configurations to build Windows on Arm builds.
This includes:
Checklist
Release Notes
Notes: no-notes