Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash in window.print() #19728

Merged
merged 2 commits into from
Aug 13, 2019
Merged

fix: crash in window.print() #19728

merged 2 commits into from
Aug 13, 2019

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Aug 13, 2019

Backport of #19690

See that PR for details.

Notes: Fixed a crash in window.print().

@trop trop bot requested a review from a team as a code owner August 13, 2019 06:44
@trop trop bot mentioned this pull request Aug 13, 2019
Merged
5 tasks
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Aug 13, 2019
@trop trop bot added 7-0-x backport This is a backport PR labels Aug 13, 2019
@codebytere codebytere force-pushed the trop/7-0-x-bp-fix-crash-in-window-print--1565678664987 branch from 7d474a0 to 788f46e Compare August 13, 2019 06:45
@codebytere codebytere removed the new-pr 🌱 PR opened in the last 24 hours label Aug 13, 2019
@codebytere codebytere merged commit c1ad66b into 7-0-x Aug 13, 2019
@release-clerk
Copy link

release-clerk bot commented Aug 13, 2019

Release Notes Persisted

Fixed a crash in window.print().

@codebytere codebytere deleted the trop/7-0-x-bp-fix-crash-in-window-print--1565678664987 branch August 13, 2019 15:02
@vbennich
Copy link
Contributor

Hi @codebytere I'm currently trying to contribute to this project in a university course and I am looking into what causes window.print() not to function twice in previous versions of Electron, mainly 5 and 6. Causing issues such as #20426 and #14705.

Is this the fix that fixes the problem? Because this issue seems to be solved in Electron 7 from the tests I've made. So would this be applicable to Electron 6? You seem the most knowledgable of this area so any input in where I might look would be very appreciative. Maybe this is a Chromium issue solved with a newer Chromium version but it would be great to fix this in previous Electron versions.
Thanks!

@christophpre
Copy link

@codebytere could this be backported to 6.1.X?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
7-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbennich @christophpre @codebytere