Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: just enough //extensions to load a simple devtools extension #19515

Merged
merged 10 commits into from Jan 15, 2020
Merged

feat: just enough //extensions to load a simple devtools extension #19515

merged 10 commits into from Jan 15, 2020

Conversation

nornagon
Copy link
Member

@nornagon nornagon commented Jul 29, 2019 •
edited

Description of Change

Depends on #19512.

Ref #19447

This adds just enough infrastructure to get a simple devtools extension loading.

Tested to be working:

  • the "devtools_page" manifest key
  • the chrome.devtools.panels.create API
  • loading JS from both the devtools page and the panel

brown-jar-seem

Checklist

Release Notes

Notes: none

(//extensions still not turned on)

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jul 29, 2019
@nornagon nornagon removed the wip ⚒ label Jul 29, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jul 30, 2019
jkleinsc
jkleinsc requested changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, but can we add a test?

@nornagon nornagon changed the base branch from disable-extensions-js to master August 1, 2019 00:01
@nornagon
Copy link
Member Author

nornagon commented Aug 1, 2019

@jkleinsc good thing you asked! found a couple bugs. will work on it more tomorrow.

@nornagon
Copy link
Member Author

@jkleinsc I (eventually) made a test :) I hope I fixed whatever bug it was that I was thinking about, because I've long since forgotten what I encountered. Test works though.

@nornagon nornagon mentioned this pull request Dec 19, 2019
Closed
11 tasks
jkleinsc
jkleinsc requested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs updated to reflect change made in #21587.

spec-main/extensions-spec.ts Outdated Show resolved Hide resolved
@nornagon
Update spec-main/extensions-spec.ts
118bb50 
Co-Authored-By: John Kleinschmidt <jkleinsc@github.com>
@nornagon nornagon merged commit 55368e4 into master Jan 15, 2020
@release-clerk
Copy link

release-clerk bot commented Jan 15, 2020

No Release Notes

@nornagon nornagon deleted the devtools-extensions branch January 15, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nornagon @jkleinsc