Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: setTimeout cannot be util.promisify'ed #13840

Merged
merged 1 commit into from Jul 30, 2018
Merged

fix: setTimeout cannot be util.promisify'ed #13840

merged 1 commit into from Jul 30, 2018

Conversation

miniak
Copy link
Contributor

@miniak miniak commented Jul 28, 2018 •
edited

Fixes #13654

Checklist

@miniak miniak requested review from zeke and a team July 28, 2018 17:03
@miniak miniak force-pushed the miniak/set-timeout-promisify branch 3 times, most recently from 9201fa7 to 33715a5 Compare July 28, 2018 17:20
@miniak miniak changed the title fix: util.promisify(setTimeout) fix: setTimeout cannot be util.promisify'ed Jul 28, 2018
MarshallOfSound
MarshallOfSound requested changes Jul 29, 2018
View reviewed changes
Copy link
Member

@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we generically do this in wrapWithActivateUvLoop instead of manually reimplementing it

@miniak miniak force-pushed the miniak/set-timeout-promisify branch from 33715a5 to d76e729 Compare July 29, 2018 09:52
@miniak
Copy link
Contributor Author

miniak commented Jul 29, 2018

@MarshallOfSound done

@miniak miniak force-pushed the miniak/set-timeout-promisify branch from d76e729 to ccc81a4 Compare July 29, 2018 09:54
@miniak miniak force-pushed the miniak/set-timeout-promisify branch from ccc81a4 to aa903db Compare July 29, 2018 11:12
@miniak miniak force-pushed the miniak/set-timeout-promisify branch 2 times, most recently from 4bba829 to 3e73b43 Compare July 29, 2018 11:44
@miniak miniak changed the title fix: setTimeout cannot be util.promisify'ed fix: node APIs cannot be util.promisify'ed Jul 29, 2018
This was referenced Jul 29, 2018
Closed
Closed
@miniak miniak force-pushed the miniak/set-timeout-promisify branch 2 times, most recently from e460b95 to 7fb1afc Compare July 29, 2018 12:29
@miniak miniak changed the title fix: node APIs cannot be util.promisify'ed fix: setTimeout cannot be util.promisify'ed Jul 29, 2018
@MarshallOfSound MarshallOfSound merged commit 39c5c20 into master Jul 30, 2018
@MarshallOfSound MarshallOfSound deleted the miniak/set-timeout-promisify branch July 30, 2018 01:14
@trop trop bot mentioned this pull request Jul 30, 2018
Merged
@trop
Copy link
Contributor

trop bot commented Jul 30, 2018

We have automatically backported this PR to "1-8-x", please check out #13858

@trop trop bot added merged/1-8-x and removed target/1-8-x labels Jul 30, 2018
@trop trop bot mentioned this pull request Jul 30, 2018
Merged
@trop
Copy link
Contributor

trop bot commented Jul 30, 2018

We have automatically backported this PR to "2-0-x", please check out #13859

@trop trop bot added merged/2-0-x and removed target/2-0-x labels Jul 30, 2018
@trop trop bot mentioned this pull request Jul 30, 2018
Merged
@trop
Copy link
Contributor

trop bot commented Jul 30, 2018

We have automatically backported this PR to "3-0-x", please check out #13860

@trop trop bot added merged/3-0-x and removed target/3-0-x labels Jul 30, 2018
@ckerr ckerr mentioned this pull request Dec 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@zeke zeke Awaiting requested review from zeke

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miniak @MarshallOfSound