Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use Visual Studio 2015 for 2-0-x and older #13607

Merged
merged 1 commit into from Jul 10, 2018
Merged

ci: Use Visual Studio 2015 for 2-0-x and older #13607

merged 1 commit into from Jul 10, 2018

Conversation

jkleinsc
Copy link
Contributor

AppVeyor has been changed to use Visual Studio 2017 15.7.4 by default for Electron builds. This PR overrides that default for 2-0-x to use Visual Studio 2015, which is what we use to build 2-0-x and older versions.

Checklist
  • PR description included and stakeholders cc'd
  • npm test passes
  • commit messages or PR title follow semantic commit guidelines

@jkleinsc jkleinsc requested a review from a team July 10, 2018 13:26
@ckerr ckerr merged commit 3e5349b into 2-0-x Jul 10, 2018
@ckerr ckerr deleted the appveyor-2-0-x branch July 10, 2018 14:40
@trop
Copy link
Contributor

trop bot commented Jul 10, 2018

We have automatically backported this PR to "1-7-x", please check out #13609

@trop
Copy link
Contributor

trop bot commented Jul 10, 2018

We have automatically backported this PR to "1-8-x", please check out #13610

@trop trop bot added merged/1-8-x and removed target/1-8-x labels Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants