Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reimplement Tray with StatusIconLinuxDbus on Linux #36472

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 28, 2022

Backport of #36333

See that PR for details.

Notes: Fix click event and tooltip of Tray not working on Linux.

Co-authored-by: Cheng Zhao <zcbenz@gmail.com>
@trop trop bot requested a review from a team as a code owner November 28, 2022 19:37
@trop trop bot requested a review from zcbenz November 28, 2022 19:37
@trop trop bot added 22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Nov 28, 2022
@jkleinsc jkleinsc merged commit 4989994 into 22-x-y Nov 29, 2022
@jkleinsc jkleinsc deleted the trop/22-x-y-bp-fix-reimplement-tray-with-statusiconlinuxdbus-on-linux-1669664214277 branch November 29, 2022 15:26
@release-clerk
Copy link

release-clerk bot commented Nov 29, 2022

Release Notes Persisted

Fix click event and tooltip of Tray not working on Linux.

@rhertzog
Copy link

rhertzog commented Jan 3, 2023

@jkleinsc I believe this shouldn't have been merged while the current chromium doesn't have the fix prepared here: https://chromium-review.googlesource.com/c/chromium/src/+/4022621
Right now apps using electron 22.x are broken on Linux systems, they can't be closed to the systray and notifications are not showing up properly either.

cf #36333 (comment)

@zcbenz
Copy link
Member

zcbenz commented Jan 3, 2023

@rhertzog Can you provide more information like which operation system and desktop environment you are using in this issue #36602?

@rhertzog
Copy link

rhertzog commented Jan 4, 2023

@rhertzog Can you provide more information like which operating system and desktop environment you are using in this issue?

Sure, done.

@zcbenz zcbenz mentioned this pull request Jan 5, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
22-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants