Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Please fix the webview docs #34678

Closed
3 tasks done
Michael-py001 opened this issue Jun 21, 2022 · 8 comments · Fixed by #36985
Closed
3 tasks done

[Bug]: Please fix the webview docs #34678

Michael-py001 opened this issue Jun 21, 2022 · 8 comments · Fixed by #36985

Comments

@Michael-py001
Copy link

Preflight Checklist

Electron Version

19.0.5

What operating system are you using?

Windows

Operating System Version

Windows 10

What arch are you using?

x64

Last Known Working Electron version

13.0.0

Expected Behavior

When I update electron from 13.0.0 to 19.0.5 ,webview's new-window event will not be triggered when I click a new url.
I searched a lot of docs and issues to find this answer . I finally found some discussions in #31117
In docs https://www.electronjs.org/docs/latest/api/web-contents#event-new-window-deprecated
Event: 'new-window' has been deprecated, but there is no any notices or declarations in webview docs: https://www.electronjs.org/docs/latest/api/webview-tag , this is so confused me. Please fix the docs.

Actual Behavior

Please fix the webview docs, add some declarations about event: 'new-window' has been deprecated.

Testcase Gist URL

No response

Additional Information

No response

@Michael-py001 Michael-py001 changed the title [Bug]: [Bug]: Please fix the webview docs Jun 21, 2022
elbywan added a commit to LedgerHQ/ledger-live that referenced this issue Jun 22, 2022
@VerteDinde VerteDinde self-assigned this Jun 29, 2022
@VerteDinde VerteDinde removed their assignment Jun 29, 2022
@avinashji1302
Copy link

hey I would like to work on this project can I get started?

@Baidaly
Copy link

Baidaly commented Aug 16, 2022

For visibility. @miniak made related changes in the following PRs:

I guess the only missing thing to close this issue is to update the document. However, main branch doesn't have that event already. Not sure how to push this change to the docs now. Restore the docs and release or make the change in a specific branch.

Can someone point to an example of how this is usually done?

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment!

@github-actions github-actions bot added the stale label Nov 15, 2022
@AniruddhaSoni
Copy link

Hey, I would like to work on this project, how can I start?

@github-actions github-actions bot removed the stale label Dec 4, 2022
@Prajjawal12
Copy link

I would like to work on this issue, please assign me this issue to resolve.

@Baidaly
Copy link

Baidaly commented Jan 20, 2023

@Michael-py001 I believe the issue is resolved as the event has been removed and documentation updated.

ritesh7785mishra added a commit to ritesh7785mishra/electron that referenced this issue Jan 21, 2023
ASAD2723 added a commit to ASAD2723/electron that referenced this issue Jan 21, 2023
amuqsit57 added a commit to amuqsit57/electron that referenced this issue Feb 4, 2023
@jenniferteaa
Copy link

Hello,
I would like to contribute to this project, Kindly let me know if i can get started

@sagar1621
Copy link

This

Hello, I would like to contribute to this project, Kindly let me know if i can get started

The issue is closed already and updated i think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Does Not Block Stable
Development

Successfully merging a pull request may close this issue.

9 participants