Fix opening external windows from a webview #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was caused by a "kinda undocumented" electron 15 breaking change see: https://www.electronjs.org/docs/latest/breaking-changes#planned-breaking-api-changes-150 and: electron/electron#31117 and: electron/electron#34678
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ebb7deb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Screenshots: ✅
There are no changes in the screenshots for this PR. If this is expected, you are good to go. |
valpinkman
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Restore the ability to open external windows from a
<webview />with the same API.This bug was caused by a "kinda undocumented" electron 15 breaking change which impacted webviews indirectly.
nativeWindowOpenhas been madetrueby default with electron 15, this PR restores the previous behaviour.Note: both webviews and the api we use are marked as deprected by Chrome and Electron. It might be a good time to rewrite.
See:
❓ Context
live-desktopN/A✅ Checklist
📸 Demo
Screen.Recording.2022-06-22.at.11.47.27.mov
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.