New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Windows 7/8 and macOS 10.11/10.12 crash when playing media files #31762
Comments
Hey @lyswhut, I just wanted to make sure I'm correctly understanding the Electron versions you listed. Are you saying this worked in 15.3.0, but is broken in both 15.3.1 and 13.6.1? |
@ckerr Yes, 14.2.1 will also crash, I have attached a demo gif |
Confirmed to be broken on Win7 7601 for E13.6.1, E14.2.1, E15.3.1. Works on E13.6.0, E14.2.0, E15.3.0. Same crash when moving audio code to renderer process. Cannot test on E16 because another Win7 issue crashes Electron too early. Log E15.3.1
Log E14.2.1
Log 13.6.1
|
I had some reports about this happening with video as well. My guess would have to be something about the recent changes to the MediaMetadata logic that was reported here. I don't believe Windows 7 supports MediaMetadata natively (It's been a while, so I might be wrong) which may explain why this issue came up with the recent releases. I'll go ahead and copy and paste the Gist I made for the MediaMetadata issue as it could be helpful with testing this as well. I don't have a Windows 7 machine to test with so I'm unsure if my Gist causes the crash or not. |
Same crash in v16.0.0 |
Comparing 13.6.0 and 13.6.1 v13.6.0...v13.6.1, there is one backport that is related to audio: https://github.com/electron/electron/pull/31521/files. |
Based on a recent stacktrace (below), it's definitely a regression caused by #31492 (this line which was previously disabled). cc @codebytere
|
Same crash on Windows 8.1. |
Yep, should be fixed by the same PR. |
Preflight Checklist
Electron Version
15.3.1
14.2.1
13.6.1
What operating system are you using?
Windows
Operating System Version
Windows 7 version 7601
What arch are you using?
x64
Last Known Working Electron version
15.3.0
14.2.0
13.6.0
Expected Behavior
Can play audio files normally
Actual Behavior
Playing certain audio files causes a crash
Testcase Gist URL
https://gist.github.com/lyswhut/cb012a765205fbb63a0683a7b1724755#file-preload-js-L13-L15
Additional Information
Working on windows 10, it will crash only under windows 7
The text was updated successfully, but these errors were encountered: