Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: <webview> transparency broken #31686

Closed
3 tasks done
miniak opened this issue Nov 3, 2021 · 6 comments · Fixed by #31722
Closed
3 tasks done

[Bug]: <webview> transparency broken #31686

miniak opened this issue Nov 3, 2021 · 6 comments · Fixed by #31722

Comments

@miniak
Copy link
Contributor

miniak commented Nov 3, 2021

Preflight Checklist

Electron Version

14.2.0 / 15.3.0 / 16.0.0-beta.6

What operating system are you using?

macOS

Operating System Version

macOS Catalina 10.15.7

What arch are you using?

x64

Last Known Working Electron version

14.0.0 / 15.0.0-beta.2

Expected Behavior

<webview> element should support trasparency. Check the included Fiddle sample.

Actual Behavior

<webview> element transparency is broken

Testcase Gist URL

No response

Additional Information

webview-transparency.zip

Screen Shot 2021-11-03 at 1 55 47 AM

Screen Shot 2021-11-03 at 1 55 53 AM

Related to:

rwhv->SetBackgroundColor(color.value_or(SK_ColorWHITE));

It regressed in this ranges:

@zcbenz
Copy link
Member

zcbenz commented Nov 3, 2021

/cc @samuelmaddock @codebytere as this is related to #30136 and #30777.

@zcbenz zcbenz added this to Unsorted Issues in 16-x-y Nov 3, 2021
@miniak
Copy link
Contributor Author

miniak commented Nov 3, 2021

The code was also changed by #31003

@zcbenz
Copy link
Member

zcbenz commented Nov 3, 2021

Can you check if #31685 can fix this?

Also @VerteDinde.

@miniak
Copy link
Contributor Author

miniak commented Nov 3, 2021

@zcbenz it does not fix this particular issue

@miniak
Copy link
Contributor Author

miniak commented Nov 3, 2021

This issue is quite a big blocker for us due to how we use <webview> to bridge our legacy AngularJS based part of the app with new ReactJS based UI

@miniak
Copy link
Contributor Author

miniak commented Nov 3, 2021

@codebytere #31685 is not fixing this bug. I've tested my Fiddle repro with the PR branch locally.
I played with the code a bit and it looks like we need to explicitly call rwhv->SetBackgroundColor(SK_ColorTRANSPARENT) for the webview.

@VerteDinde VerteDinde self-assigned this Nov 3, 2021
@VerteDinde VerteDinde moved this from Unsorted Issues to Blocks Stable in 16-x-y Nov 3, 2021
@VerteDinde VerteDinde moved this from Blocks Stable to Fixed For Next Release in 16-x-y Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
16-x-y
Fixed For Next Release
Development

Successfully merging a pull request may close this issue.

3 participants