Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix code example in process-model.md #30800

Merged
merged 1 commit into from Sep 1, 2021

Conversation

erickzhao
Copy link
Member

Backport of #30690

See that PR for details

notes: none

* Update process-model.md

the demo have two error:
- at macos, close all window, the app will not quite, unless press cmd + q
- attach preload.js, use preload prop that is member of `webPreferences` property of `BrowserWindow` controller argument

* Update docs/tutorial/process-model.md

Co-authored-by: Erick Zhao <erick@hotmail.ca>

Co-authored-by: Cheng Zhao <github@zcbenz.com>
Co-authored-by: Erick Zhao <erick@hotmail.ca>
@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Sep 1, 2021
@trop trop bot added 14-x-y backport This is a backport PR semver/none labels Sep 1, 2021
@erickzhao erickzhao requested a review from a team September 1, 2021 22:05
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Sep 1, 2021
@MarshallOfSound MarshallOfSound merged commit c0da647 into electron:14-x-y Sep 1, 2021
@release-clerk
Copy link

release-clerk bot commented Sep 1, 2021

No Release Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants