chore: cherry-pick fix for 1234009 from chromium #30635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
changed the title
This was referenced Aug 25, 2021
deepak1556
approved these changes
Aug 30, 2021
|
Release Notes Persisted
|
This was referenced Aug 30, 2021
|
I have automatically backported this PR to "11-x-y", please check out #30751 |
|
I have automatically backported this PR to "12-x-y", please check out #30752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer looking up the WebContents for the directory confirmation dialog.
Look up the WebContents to use for the sensitive directory confirmation
dialog immediately before it's used instead of before performing some
blocking file access to determine whether it's necessary.
Bug: 1234009
Change-Id: I5e00c7fa199b3da522e1fdb73242891d7f5f7423
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3063743
Reviewed-by: Alex Danilo adanilo@chromium.org
Reviewed-by: Ben Wells benwells@chromium.org
Commit-Queue: Sam McNally sammc@chromium.org
[modify] https://crrev.com/18236a0db8341302120c60781ae3129e94fbaf1c/extensions/browser/api/file_system/file_system_api.cc
[modify] https://crrev.com/18236a0db8341302120c60781ae3129e94fbaf1c/extensions/browser/api/file_system/file_system_api.h
Notes: Security: Backported fix for 1234009.