Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Renderer crashes when using fsPromises.readFile in a native child window #29920

Closed
3 tasks done
Maxime117 opened this issue Jun 28, 2021 · 3 comments
Closed
3 tasks done

Comments

@Maxime117
Copy link

Preflight Checklist

Electron Version

12.0.12

What operating system are you using?

macOS

Operating System Version

macOS Big Sur 11.4

What arch are you using?

x64

Last Known Working Electron version

12.0.11

Expected Behavior

fsPromises.readFile should resolve with data or reject with an error.

Actual Behavior

The child and its parent renderer crashes.

Testcase Gist URL

https://github.com/Maxime117/fsPromises-readFile-crash

Additional Information

Non-promise version of readFile is working as well as fsPromises.stat for example.

Main process log:

~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Helper (Renderer).app/Contents/MacOS/Electron Helper (Renderer)[87938]: ../../third_party/electron_node/src/api/callback.cc:62:node::InternalCallbackScope::InternalCallbackScope(node::Environment *, Local<v8::Object>, const node::async_context &, int): Assertion `(Environment::GetCurrent(env->isolate())) == (env)' failed.
 1: 0x1174bbca5 node::Buffer::New(v8::Isolate*, char*, unsigned long, void (*)(char*, void*), void*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 2: 0x1174bbabb node::Buffer::New(v8::Isolate*, char*, unsigned long, void (*)(char*, void*), void*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 3: 0x1174307db node::CallbackScope::~CallbackScope() [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 4: 0x11743083e node::CallbackScope::~CallbackScope() [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 5: 0x1174bf349 node::OnFatalError(char const*, char const*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 6: 0x1174d419a node::OnFatalError(char const*, char const*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 7: 0x114d911a8 uv_random [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 8: 0x114d94f40 uv_async_send [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
 9: 0x114da6659 uv_free_interface_addresses [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
10: 0x114d9538c uv_run [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
11: 0x114ef88f4 ElectronInitializeICUandStartNode [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
12: 0x115f87b99 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
13: 0x115f961de v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
14: 0x115f95cfe v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
15: 0x115fca3c3 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
16: 0x115fc6e5a v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
17: 0x115fc9d8f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
18: 0x7fff206ae97c __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation]
19: 0x7fff206ae8e4 __CFRunLoopDoSource0 [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation]
20: 0x7fff206ae664 __CFRunLoopDoSources0 [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation]
21: 0x7fff206ad08c __CFRunLoopRun [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation]
22: 0x7fff206ac64c CFRunLoopRunSpecific [/System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation]
23: 0x7fff2143a647 -[NSRunLoop(NSRunLoop) runMode:beforeDate:] [/System/Library/Frameworks/Foundation.framework/Versions/C/Foundation]
24: 0x115fca8d4 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
25: 0x115fc991b v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
26: 0x115f96c3f v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
27: 0x115f73f59 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
28: 0x1173f0668 v8::internal::SetupIsolateDelegate::SetupHeap(v8::internal::Heap*) [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
29: 0x11535a47a electron::fuses::IsRunAsNodeEnabled() [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
30: 0x115359170 electron::fuses::IsRunAsNodeEnabled() [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
31: 0x115359632 electron::fuses::IsRunAsNodeEnabled() [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
32: 0x114da6c88 ElectronMain [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Framework.framework/Versions/A/Electron Framework]
33: 0x10fb02d49  [~/fsPromises-readFile-crash/node_modules/electron/dist/Electron.app/Contents/Frameworks/Electron Helper (Renderer).app/Contents/MacOS/Electron Helper (Renderer)]
34: 0x7fff205d0f5d start [/usr/lib/system/libdyld.dylib]
35: 0x17 
@nornagon
Copy link
Member

nornagon commented Jun 28, 2021

hm... cc @indutny and @codebytere who might have ideas about this.

@codebytere codebytere self-assigned this Jun 28, 2021
@codebytere
Copy link
Member

Oops looks like I accidentally closed this, my bad 🙈

@codebytere
Copy link
Member

Closed in #29928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants