fix: fsPromises.readFile renderer crash #29928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/patch
nornagon
approved these changes
Jun 28, 2021
jkleinsc
approved these changes
Jun 29, 2021
codebytere
force-pushed
the
fix-context-crash
branch
from
335e06c
to
4fc70b2
Compare
zcbenz
approved these changes
Jul 6, 2021
|
Release Notes Persisted
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #29920.
This was occurring because Node.js wasn't properly entering the
v8::Contextbefore resolving the Promise. This was fixed in nodejs/node#36413 which is present in v14.17.0 and beyond, and so needs to be backported only to v12 and v13.Checklist
npm testpassesRelease Notes
Notes: Fixed a possible renderer crash when using
fsPromises.readFile.