Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: isTrustedSender() in test-app #24232

Merged
merged 1 commit into from Jun 22, 2020
Merged

fix: isTrustedSender() in test-app #24232

merged 1 commit into from Jun 22, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Jun 22, 2020

Backport of #24214

See that PR for details.

Notes: Fixed "null path-to-app" in test-app when Electron's path contains spaces or special characters.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jun 22, 2020
@trop trop bot requested a review from miniak June 22, 2020 12:15
@trop trop bot mentioned this pull request Jun 22, 2020
Merged
5 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Jun 22, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Jun 22, 2020
@codebytere codebytere merged commit 3704dc9 into 9-x-y Jun 22, 2020
@release-clerk
Copy link

release-clerk bot commented Jun 22, 2020

Release Notes Persisted

Fixed "null path-to-app" in test-app when Electron's path contains spaces or special characters.

@codebytere codebytere deleted the trop/9-x-y-bp-fix-istrustedsender-in-test-app-1592828104941 branch June 22, 2020 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@miniak miniak Awaiting requested review from miniak

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codebytere @miniak