Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: weakly reference MenuModel from MenuController #23808

Merged
merged 1 commit into from May 28, 2020
Merged

fix: weakly reference MenuModel from MenuController #23808

merged 1 commit into from May 28, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 27, 2020

Backport of #23778

See that PR for details.

Notes: Fixed an occasional menu crash on macOS Catalina when menu is closing.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 27, 2020
@trop trop bot requested a review from codebytere May 27, 2020 20:55
@trop trop bot mentioned this pull request May 27, 2020
Merged
4 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels May 27, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 27, 2020
@codebytere codebytere merged commit 568d38c into 9-x-y May 28, 2020
@release-clerk
Copy link

release-clerk bot commented May 28, 2020

Release Notes Persisted

Fixed an occasional menu crash on macOS Catalina when menu is closing.

@codebytere codebytere deleted the trop/9-x-y-bp-fix-weakly-reference-menumodel-from-menucontroller-1590612921032 branch May 28, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@codebytere