Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve MoveItemToTrash error description #23628

Merged
merged 1 commit into from May 19, 2020
Merged

refactor: improve MoveItemToTrash error description #23628

merged 1 commit into from May 19, 2020

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented May 18, 2020

Backport of #23589

See that PR for details.

Notes: Improved error logging on moveItemToTrash failures on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label May 18, 2020
@trop trop bot requested a review from codebytere May 18, 2020 02:19
@trop trop bot mentioned this pull request May 18, 2020
Merged
4 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels May 18, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label May 18, 2020
@codebytere codebytere merged commit 69a343e into 9-x-y May 19, 2020
@release-clerk
Copy link

release-clerk bot commented May 19, 2020

Release Notes Persisted

Improved error logging on moveItemToTrash failures on macOS.

@codebytere codebytere deleted the trop/9-x-y-bp-refactor-improve-moveitemtotrash-error-description-1589768332573 branch May 19, 2020 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zcbenz @codebytere