New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print issue on Electron from v7 - Print only works once (window.print()) #21397
Comments
@ChenAlon Running that exact gist on |
@codebytere, yes. Did you see the video? Here are some logs from the Console app logs: This happen after I click the print button:
And this after I click Print on the Print dialog (Save to PDF):
|
I'll do my best to check into this! |
I think this should block a stable release until fixed. Only being able to print once seems like a pretty severe issue. I know it's a show-stopper for us. We tried resolving by rolling back to v6.x, but then got hit with #19768 . In our case (site wrapper) the workarounds don't help, so we're pretty much stuck. IMO getting back to print stability in v8 would finally take this off the table. |
@daveajones i'll be working on this soon. |
I can confirm this in v8.0.0-beta.7 |
@barbalex yes, as you can see above i PR'd a fix into this yesterday. That means it will be fixed in the next released versions of 6, 7, and 8. |
@codebytere sorry, that printing works only once. And yes, obviously your merge will only be in the next release so sorry for bugging. And THANKS A LOT for solving the issue! |
@barbalex of course! printing is an ongoing struggle so apologies for the occasional failures, but it's something i care about to large extent so i'm always happy to tackle printing bugs when they come up :D |
Hi, I am encountering the exact same problem in version 10.1.1 (latest version currently) on mac. Can anyone else please confirm if the issue has been reintroduced? Btw, I have tried to approaches to printing:
PS: I am new to electron. Thank you! Update: I downgraded to 7.1.11 and it seems to be working. Looks like it has been reintroduced. |
Downgrade to version 1.8. Works to me. |
I just tested with https://gist.github.com/0f0e776b138452d6815ef4efc16aa0d1 and had no issues running window.print multiple times on v10 with macOS. Additionally you absolutely do not want to use a version as old as 1.8 for any reason. Edit: found an issue i think - it looks specific to 10 though as i cannot reproduce it on 11 and master. I'll try to suss it out. |
@codebytere thank you for that gist. I will compare your gist with my code and update you here. |
I still have problems on version 13 and 14. |
Preflight Checklist
Issue Details
Not working since v7.00.
Tested on:
Expected Behavior
That the
window.print()
will work, even after the first time.Like in versions prior to v7.0.0
Actual Behavior
The
window.print()
function only works one time.After the first time, it's not working.
The print dialog appears but the actual printing is not.
To Reproduce
Run
window.print()
twice.On the Electron Fiddle app example, click on the Print Page and print.
After that first time, click on the Print Page button again and try to print again.
Link to the Gist
Screenshots
Link to video
The text was updated successfully, but these errors were encountered: