New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multiple window.print() crash #25530
Conversation
Failure is:
and is unrelated. |
Release Notes Persisted
|
Hi @codebytere, does this fix released in any 10-x-y? I'm using 10.1.2 Electron still crashes when print 2nd time... |
@BryanYin nope! not yet |
Thanks for the fix! |
@codebytere tried with new 10.1.3, the issue is gone! Thanks for your efforts! |
Windows 7 missing some content while print ,I am using electron 8.5 |
Description of Change
Refs #21397 (comment).
Fixes an issue where the notification registrar would try to remove an already-removed listener during print job release. This has already been handled in
master
and11-x-y
and so can directly target10-x-y
.cc @MarshallOfSound @zcbenz @deepak1556
Checklist
npm test
passesRelease Notes
Notes: Fixed an issue where multiple calls to
window.print()
could cause a crash.