Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't copy tray image when it's set #20935

Conversation

trop[bot]
Copy link
Contributor

@trop trop bot commented Nov 2, 2019

Backport of #20904

See that PR for details.

Notes: Fixed a memory leak issue when setting Tray images.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Nov 2, 2019
@trop trop bot mentioned this pull request Nov 2, 2019
4 tasks
@trop trop bot added 7-0-x backport This is a backport PR labels Nov 2, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 2, 2019
@MarshallOfSound MarshallOfSound merged commit 37c1df6 into 7-0-x Nov 4, 2019
@release-clerk
Copy link

release-clerk bot commented Nov 4, 2019

Release Notes Persisted

Fixed a memory leak issue when setting Tray images.

@MarshallOfSound MarshallOfSound deleted the trop/7-0-x-bp-fix-don-t-copy-tray-image-when-it-s-set-1572732912368 branch November 4, 2019 22:17
@deepak1556
Copy link
Member

deepak1556 commented Nov 7, 2019

@codebytere Should have targeted 7-1-x :)

@codebytere
Copy link
Member

/trop run backport-to 7-1-x

@trop
Copy link
Contributor Author

trop bot commented Nov 7, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "7-1-x" here we go! :D

@trop
Copy link
Contributor Author

trop bot commented Nov 7, 2019

I was unable to backport this PR to "7-1-x" cleanly;
you will need to perform this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7-0-x backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants