fix: don't copy tray image when it's set (#20935)

electron · Nov 4, 2019 · 37c1df6 · 37c1df6
1 parent d9068b7
commit 37c1df6
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/shell/browser/ui/tray_icon_cocoa.mm b/shell/browser/ui/tray_icon_cocoa.mm
@@ -87,12 +87,12 @@ - (void)removeItem {
 }
 
 - (void)setImage:(NSImage*)image {
-  [[statusItem_ button] setImage:[image copy]];
+  [[statusItem_ button] setImage:image];
   [self updateDimensions];
 }
 
 - (void)setAlternateImage:(NSImage*)image {
-  [[statusItem_ button] setAlternateImage:[image copy]];
+  [[statusItem_ button] setAlternateImage:image];
 }
 
 - (void)setIgnoreDoubleClickEvents:(BOOL)ignore {
@@ -108,7 +108,7 @@ - (void)setTitle:(NSString*)title {
     [[statusItem_ button]
         setAttributedTitle:[title attributedStringParsingANSICodes]];
   } else {
-    [[statusItem_ button] setTitle:[title copy]];
+    [[statusItem_ button] setTitle:title];
   }
 
   // Fix icon margins.