fix: prevent menu gc during popup #20808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![trop[bot]](https://avatars.githubusercontent.com/in/9879?s=60&v=4){kind=small}
codebytere
approved these changes
Oct 29, 2019
zcbenz
approved these changes
Oct 29, 2019
|
Release Notes Persisted
|
zcbenz
deleted the
trop/7-0-x-bp-fix-prevent-menu-gc-during-popup-1572322882292
branch
|
menu.popup() is crashing my app in Electron 7.1.2. |
|
@dgmid Can you create a new issue with the test app and details about your environment? |
|
Done: #21338 |
|
@dgmid I can not reproduce it on my machine, can you also paste the crash report? It can be found in |
|
No problem, here it is: I have also tested this on my old Macbook Pro which is running macOS 10.13.6 (High Sierra) and it doesn't crash that machine. Only the 10.15.1 (Catalina) machine. |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20785
See that PR for details.
Notes: Fixed a crash in Menus related to
menu.popup().