fix: crash on missing render frame

electron · Oct 5, 2021 · ed8ee5e · ed8ee5e
1 parent 4fd7c2a
commit ed8ee5e
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/shell/browser/api/electron_api_web_contents.cc b/shell/browser/api/electron_api_web_contents.cc
@@ -1697,9 +1697,14 @@ void WebContents::MessageTo(int32_t web_contents_id,
     gin::Handle<WebFrameMain> web_frame_main =
         WebFrameMain::From(JavascriptEnvironment::GetIsolate(), frame);
 
-    int32_t sender_id = ID();
-    web_frame_main->GetRendererApi()->Message(false /* internal */, channel,
-                                              std::move(arguments), sender_id);
+    if (!web_frame_main->CheckRenderFrame())
+      return;
+
+    if () {
+      int32_t sender_id = ID();
+      web_frame_main->GetRendererApi()->Message(
+          false /* internal */, channel, std::move(arguments), sender_id);
+    }
   }
 }