Skip to content

Commit

Permalink
fix: use win_clang_x64 binary for x86 extract symbols (#35090)
Browse files Browse the repository at this point in the history
fix: use win_clang_x64 for x86 extract symbols

Co-authored-by: Keeley Hammond <khammond@slack-corp.com>
  • Loading branch information
trop[bot] and VerteDinde committed Jul 27, 2022
1 parent 9df18f3 commit ea21d94
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion build/extract_symbols.gni
Expand Up @@ -24,7 +24,11 @@ template("extract_symbols") {
assert(defined(invoker.binary), "Need binary to dump")
assert(defined(invoker.symbol_dir), "Need directory for symbol output")

dump_syms_label = "//third_party/breakpad:dump_syms($host_toolchain)"
if (host_os == "win" && target_cpu == "x86") {
dump_syms_label = "//third_party/breakpad:dump_syms(//build/toolchain/win:win_clang_x64)"
} else {
dump_syms_label = "//third_party/breakpad:dump_syms($host_toolchain)"
}
dump_syms_binary = get_label_info(dump_syms_label, "root_out_dir") +
"/dump_syms$_host_executable_suffix"

Expand Down

0 comments on commit ea21d94

Please sign in to comment.