fix: menu window should not appear in taskbar

electron · Jun 15, 2020 · ddf24c1 · ddf24c1
1 parent 04e010f
commit ddf24c1
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/patches/chromium/.patches b/patches/chromium/.patches
@@ -100,3 +100,4 @@ disable_dcheck_that_fails_with_software_compositing.patch
 fix_swap_global_proxies_before_initializing_the_windows_proxies.patch
 fix_default_to_ntlm_v2_in_network_service.patch
 feat_add_streaming-protocol_registry_to_multibuffer_data_source.patch
+remove_menu_window_task_item.patch
diff --git a/patches/chromium/remove_menu_window_task_item.patch b/patches/chromium/remove_menu_window_task_item.patch
@@ -0,0 +1,19 @@
+From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
+From: Cheng Zhao <zcbenz@gmail.com>
+Date: Thu, 4 Oct 2018 14:57:02 -0700
+Subject: fix: remove menu window from taskbar
+
+Refs https://chromium-review.googlesource.com/c/chromium/src/+/2245941
+
+diff --git a/ui/views/widget/widget_hwnd_utils.cc b/ui/views/widget/widget_hwnd_utils.cc
+index 40e66a212e3ea158b61f11d804a3c1644023b2d7..d3cdffc67216efa81f1c7394ee653a1d66207bd2 100644
+--- a/ui/views/widget/widget_hwnd_utils.cc
++++ b/ui/views/widget/widget_hwnd_utils.cc
+@@ -109,6 +109,7 @@ void CalculateWindowStylesFromInitParams(
+       break;
+     case Widget::InitParams::TYPE_MENU:
+       *style |= WS_POPUP;
++      *ex_style |= WS_EX_TOOLWINDOW;
+       if (::features::IsFormControlsRefreshEnabled() &&
+           params.remove_standard_frame) {
+         // If the platform doesn't support drop shadow, decorate the Window