fix: only notify mouse-up on mouse-up (#24240)

electron · Jun 23, 2020 · acb64a2 · acb64a2
1 parent 3853fd3
commit acb64a2
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/shell/browser/ui/tray_icon_cocoa.mm b/shell/browser/ui/tray_icon_cocoa.mm
@@ -131,10 +131,6 @@ - (void)setMenuController:(ElectronMenuController*)menu {
 }
 
 - (void)handleClickNotifications:(NSEvent*)event {
-  trayIcon_->NotifyMouseUp(
-      gfx::ScreenPointFromNSPoint([event locationInWindow]),
-      ui::EventFlagsFromModifiers([event modifierFlags]));
-
   // If we are ignoring double click events, we should ignore the `clickCount`
   // value and immediately emit a click event.
   BOOL shouldBeHandledAsASingleClick =
@@ -172,6 +168,10 @@ - (void)mouseDown:(NSEvent*)event {
 - (void)mouseUp:(NSEvent*)event {
   [[statusItem_ button] highlight:NO];
 
+  trayIcon_->NotifyMouseUp(
+      gfx::ScreenPointFromNSPoint([event locationInWindow]),
+      ui::EventFlagsFromModifiers([event modifierFlags]));
+
   [self handleClickNotifications:event];
 }