fix: ensure bluetooth devices are not returned by default (#32195)

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
electron · Dec 16, 2021 · a6f0482 · a6f0482
1 parent 9961c7a
commit a6f0482
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/docs/api/web-contents.md b/docs/api/web-contents.md
@@ -730,6 +730,8 @@ first available device will be selected. `callback` should be called with
 `deviceId` to be selected, passing empty string to `callback` will
 cancel the request.
 
+If no event listener is added for this event, all bluetooth requests will be cancelled.
+
 ```javascript
 const { app, BrowserWindow } = require('electron')
 

diff --git a/lib/browser/api/web-contents.ts b/lib/browser/api/web-contents.ts
@@ -681,6 +681,14 @@ WebContents.prototype._init = function () {
     }
   });
 
+  this.on('select-bluetooth-device', (event, devices, callback) => {
+    if (this.listenerCount('select-bluetooth-device') === 0) {
+      // Cancel it if there are no handlers
+      event.preventDefault();
+      callback('');
+    }
+  });
+
   const event = process._linkedBinding('electron_browser_event').createEmpty();
   app.emit('web-contents-created', event, this);