Address feedback from review

electron · Sep 14, 2020 · 87b2259 · 87b2259
1 parent 45f8abc
commit 87b2259
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/lib/browser/api/web-contents.ts b/lib/browser/api/web-contents.ts
@@ -461,6 +461,11 @@ const addReturnValueToEvent = (event: any) => {
   });
 };
 
+const loggingEnabled = () => {
+  return Object.prototype.hasOwnProperty.call(process.env, 'ELECTRON_ENABLE_LOGGING') ||
+    process.argv.some(arg => arg.toLowerCase().startsWith('--enable-logging'));
+};
+
 // Add JavaScript wrappers for WebContents class.
 WebContents.prototype._init = function () {
   // The navigation controller.
@@ -545,8 +550,8 @@ WebContents.prototype._init = function () {
     app.emit('renderer-process-crashed', event, this, ...args);
 
     // Log out a hint to help users better debug renderer crashes.
-    if (!process.env.ELECTRON_ENABLE_LOGGING) {
-      console.info('Renderer process crashed - setting ELECTRON_ENABLE_LOGGING may provide more information.');
+    if (loggingEnabled()) {
+      console.info('Renderer process crashed - see https://www.electronjs.org/docs/tutorial/application-debugging for potential debugging information.');
     }
   });