fix: call node::Stop on exit (#25459)

* fix: call node::Stop on exit * also call Stop in node_main * oop, we were already calling set_can_call_into_js(false)?? Co-authored-by: Jeremy Rose <nornagon@nornagon.net>
electron · Sep 16, 2020 · 80efb6d · 80efb6d
1 parent 51a35f8
commit 80efb6d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/shell/app/node_main.cc b/shell/app/node_main.cc
@@ -284,7 +284,7 @@ int NodeMain(int argc, char* argv[]) {
 
     node::ResetStdio();
 
-    env->set_can_call_into_js(false);
+    node::Stop(env);
     env->stop_sub_worker_contexts();
     env->RunCleanup();
 

diff --git a/shell/browser/electron_browser_main_parts.cc b/shell/browser/electron_browser_main_parts.cc
@@ -553,6 +553,7 @@ void ElectronBrowserMainParts::PostMainMessageLoopRun() {
   node_debugger_->Stop();
   node_env_->env()->set_trace_sync_io(false);
   js_env_->OnMessageLoopDestroying();
+  node::Stop(node_env_->env());
   node_env_.reset();
 
   ElectronBrowserContext::browser_context_map().clear();