fix: session argument of app 'session-created' event (#25798)

Co-authored-by: Milan Burda <miburda@microsoft.com>
electron · Oct 8, 2020 · 7ae4b2b · 7ae4b2b
1 parent 244f405
commit 7ae4b2b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/lib/browser/api/app.ts b/lib/browser/api/app.ts
@@ -135,6 +135,10 @@ for (const name of events) {
   });
 }
 
+app.on('-session-created' as any, (event, session) => {
+  app.emit('session-created', session);
+});
+
 // Deprecate allowRendererProcessReuse but only if they set it to false, no need to log if
 // they are setting it to true
 deprecate.removeProperty(app, 'allowRendererProcessReuse', [false]);
diff --git a/shell/browser/api/electron_api_session.cc b/shell/browser/api/electron_api_session.cc
@@ -950,8 +950,7 @@ gin::Handle<Session> Session::CreateFrom(
   ElectronBrowserMainParts::Get()->RegisterDestructionCallback(
       base::BindOnce([](Session* session) { delete session; }, handle.get()));
 
-  App::Get()->EmitCustomEvent("session-created",
-                              handle.ToV8().As<v8::Object>());
+  App::Get()->Emit("-session-created", handle.ToV8().As<v8::Object>());
 
   return handle;
 }