Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: use Node's microtasks policy in node_main.cc (#23154)
Fixes #21515.
- Loading branch information
Showing
3 changed files
with
37 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
const waitMs = (msec) => new Promise((resolve) => setTimeout(resolve, msec)); | ||
|
||
const intervalMsec = 100; | ||
const numIterations = 2; | ||
let curIteration = 0; | ||
let promise; | ||
|
||
for (let i = 0; i < numIterations; i++) { | ||
promise = (promise || waitMs(intervalMsec)).then(() => { | ||
++curIteration; | ||
return waitMs(intervalMsec); | ||
}); | ||
} | ||
|
||
// https://github.com/electron/electron/issues/21515 was about electron | ||
// exiting before promises finished. This test sets the pending exitCode | ||
// to failure, then resets it to success only if all promises finish. | ||
process.exitCode = 1; | ||
promise.then(() => { | ||
if (curIteration === numIterations) { | ||
process.exitCode = 0; | ||
} | ||
}); |