fix: test failing possibly caused by lazy loaded iframes?

electron · May 22, 2021 · 541a9a3 · 541a9a3
1 parent bc69d7b
commit 541a9a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/spec-main/api-web-contents-spec.ts b/spec-main/api-web-contents-spec.ts
@@ -2058,25 +2058,15 @@ describe('webContents module', () => {
 
   describe('frame-dom-ready event', () => {
     it('emits for top-level frame', async () => {
-      const w = new BrowserWindow({
-        show: false,
-        webPreferences: {
-          sandbox: true
-        }
-      });
+      const w = new BrowserWindow({ show: false });
       const promise = emittedOnce(w.webContents, 'frame-dom-ready');
       w.webContents.loadURL('about:blank');
       const [, frame] = await promise;
       expect(frame).to.equal(w.webContents.mainFrame);
     });
 
     it('emits for sub frame', async () => {
-      const w = new BrowserWindow({
-        show: false,
-        webPreferences: {
-          sandbox: true
-        }
-      });
+      const w = new BrowserWindow({ show: false });
       const promise = new Promise<void>(resolve => {
         w.webContents.on('frame-dom-ready', (e, frame) => {
           if (frame.name === 'frameA') {

diff --git a/spec-main/fixtures/sub-frames/frame-with-frame.html b/spec-main/fixtures/sub-frames/frame-with-frame.html
@@ -8,6 +8,6 @@
 </head>
 <body>
   This is a frame, is has one child
-  <iframe src="./frame.html" name="frameA"></iframe>
+  <iframe src="./frame.html" name="frameA" loading="eager"></iframe>
 </body>
 </html>